Creating Conversation Quickstart for Go #1128
Open
+374
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
rochabr
changed the title
mikeee
requested changes
Jan 21, 2025
| match_order: none | ||
| background: false | ||
| sleep: 5 | ||
| timeout_seconds: 120 |
There was a problem hiding this comment.
Just a nit- has this been validated with a much shorter timeout? Our workflows take far too long with waits at the moment and I can't imagine the execution time being very long
Co-authored-by: Mike Nguyen <[email protected]> Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]> Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]> Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]> Signed-off-by: Fernando Rocha <[email protected]>
mikeee
requested changes
Jan 23, 2025
| apps: | ||
| - appDirPath: ./conversation/ | ||
| appID: conversation | ||
| appPort: 3500 |
There was a problem hiding this comment.
This is unused
Suggested change
| appPort: 3500 |
| apps: | ||
| - appDirPath: ./conversation/ | ||
| appID: conversation | ||
| appPort: 3500 |
There was a problem hiding this comment.
Unused
Suggested change
| appPort: 3500 |
| - appDirPath: ./conversation/ | ||
| appID: conversation | ||
| appPort: 3500 | ||
| daprHTTPPort: 3501 |
There was a problem hiding this comment.
Suggested change
| daprHTTPPort: 3501 |
Unused - unless a grpc port is preferable?
| match_order: none | ||
| background: false | ||
| sleep: 5 | ||
| timeout_seconds: 120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Conversation building block SDK and HTTP quickstart samples.